SCC-4407 - EDD Form Prepopulate Patron Email #422
Merged
+33
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
EdwinGuzman
approved these changes
Dec 18, 2024
charmingduchess
requested changes
Dec 20, 2024
pages/hold/request/[id]/edd.tsx
Outdated
| @@ -250,6 +253,10 @@ export async function getServerSideProps({ params, req, res }) { | |||
|
|
|||
| const patronEligibilityStatus = await fetchPatronEligibility(patronId) | |||
|
|
|||
| // fetch patron's email to pre-populate the edd form if available | |||
| const patronData = await getPatronData(patronId) | |||
There was a problem hiding this comment.
this is fetching a lot of patron data, though it doesn't appear to be taking a very long time. I still think that instead of using getPatronData, which builds out a whole my account dataset including checkouts and holds and fines, maybe you can use the MyAccount model's getPatron
There was a problem hiding this comment.
Don't I still need to initialize a MyAccount data model to use the getPatron function?
There was a problem hiding this comment.
We talked offline and I ended up using MyAccount's getPatron function instead of calling getPatronData() since this counterintuitively involves less data instantiation.
charmingduchess
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket:
This PR does the following:
How has this been tested?
Accessibility concerns or updates
Checklist: